Clunking/rattle noise while driving
 

I have 2005 525i with a clunking rattling noise while driving it dont have to be bumpy roads but it's quite obvious on bumpy roads. Sounds like it's the driver's side lh steering. I changed the end like & both arms and strut mount (but shock itself is bad because I pushed down but wouldn't go back up). Could it indeed be the bad shock?
https://youtube.com/shorts/QMzjsuvK8mA?feature=share

That could be a strut, or a swaybar link, based on the sound. I'd also suggest taking a close look at the rest of the suspension - ball joints, bushings, bearings, etc. Basically just look for anything that's loose or looks worn.

I replaced both arms on both sides including the ball joints so all that is new. The bushings in the arms are new also. Along with the outter tie rod. But thing is o never heard or thought of ppl mention rattle clunking in the strut assembly. So this mind boggling

You can get that with a bad strut mount

both strut mount has been replaced.

What brand was the strut mount?

Also, it would be (easily) possible to install a good strut mount incorrectly and get that kind of noise. Probably the easiest way to check would be to lift the front corner(s) of the car and check for any looseness at the top of the strut.

hmmm. Quick question, when i took the old strut mount off two lil washer type plates fell out i put one on. LAIPZ or something is the manufacturer ebay aka evilbay.

I think you've answered your own questions... there's a possibility that the strut mounts are not up to snuff (not sure where LAIPZ sources their parts, but they're most likely not "OEM quality"), and it's unusual to be able to leave a part or two out without bad results. I'd recommend digging in and find a DIY or video on the installation process and figure out where both of those metal "washers" go, and correct that. That'll most likely fix your issue.